Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular Issues: view.js:59 Uncaught TypeError: Cannot set properties of undefined (setting 'innerHTML') #4187

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Angular Issues: view.js:59 Uncaught TypeError: Cannot set properties of undefined (setting 'innerHTML') #4187

merged 1 commit into from
Feb 27, 2024

Conversation

LNAhri
Copy link
Contributor

@LNAhri LNAhri commented Jan 25, 2024 •
edited
Loading

In Angular you sometimes run into complete Flow Errors when Element was already unmounted and it tries to unmount it again

Description

Move the Unmount Function after the null check for the container to not kill the environment completly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Self Check before Merge

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@LNAhri
Update view.ts
91d57b3 
In Angular you sometimes run into complete Flow Errors when Element was already unmounted and it ttries to unmount it again
@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 25, 2024

👋 @LNAhri

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@NewByVector NewByVector merged commit 705fbdb into antvis:master Feb 27, 2024
16 of 17 checks passed
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 27, 2024

👋 @LNAhri

Congrats on merging your first pull request! 🎉🎉🎉

@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewByVector NewByVector NewByVector approved these changes

Assignees
No one assigned
Labels
PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LNAhri @NewByVector